-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix biasScaleShape of GroupNormalizationV21 to support ranks > 4 #3030
Fix biasScaleShape of GroupNormalizationV21 to support ranks > 4 #3030
Conversation
@jorickert Hello!! Can you direct me to the link or document which validates your findings please? I just want to have a better understanding. Thank you! |
@hamptonm1 The formula for GroupNorm is: Internally, the GroupNorm reshapes the input to The decomposition/conversion mimics this:
While writing this down, I realized, that the lit tests are still wrong for GroupNormV21. The input scale and bias have the size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let me know if you need me to merge it (and if so, when you are ready to do so),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay it works for me then!
aaa9a68
to
0c65cec
Compare
@AlexandreEichenberger It would be nice if you could merge this. Thank you |
Signed-off-by: Rickert, Jonas <[email protected]>
For V21 the scale and bias have size C, not C//G Signed-off-by: Rickert, Jonas <[email protected]>
0c65cec
to
044c80c
Compare
Jenkins Linux s390x Build #16093 [push] Fix biasScaleShape of Gr... started at 13:08 |
Jenkins Linux amd64 Build #16091 [push] Fix biasScaleShape of Gr... started at 12:08 |
Jenkins Linux ppc64le Build #15120 [push] Fix biasScaleShape of Gr... started at 13:25 |
Jenkins Linux s390x Build #16093 [push] Fix biasScaleShape of Gr... passed after 1 hr 29 min |
Jenkins Linux amd64 Build #16091 [push] Fix biasScaleShape of Gr... passed after 1 hr 30 min |
Jenkins Linux ppc64le Build #15120 [push] Fix biasScaleShape of Gr... passed after 2 hr 26 min |
Before this PR the
oneDimShape
assumed a spacial rank of two, which is only correct for rank==4.